Opened 20 months ago

Closed 18 months ago

Last modified 18 months ago

#23782 closed enhancement (fixed)

Expose all possible query features in an "Advanced Search" HTML form

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Atlas does support much more than IP/nickname search. Most users do not know that.
An "Advanced Search" form should show all possible search fields and make it easy to create advanced queries without having to know every parameter.

  • country
  • AS
  • running
  • flags
  • first_seen_days

....

Child Tickets

Change History (12)

comment:1 Changed 20 months ago by irl

Parent ID: #23518

I think this can be done as part of #23518, integrating Atlas functionality into the Tor Metrics website.

comment:2 Changed 18 months ago by irl

Owner: changed from metrics-team to irl
Status: newaccepted

Moving these into my queue.

comment:3 Changed 18 months ago by irl

When we have advanced queries, we should update exit_address links to search for exact matches instead of the inline search parameters.

https://lists.torproject.org/pipermail/metrics-team/2017-November/000566.html

comment:4 Changed 18 months ago by irl

Parent ID: #23518

The parameter that would need doesn't exist in Onionoo, so actually we can't make those exact matches. With the updating of Backbone.js however, this no longer blocks on #23518 as we can now have optional parts to the URL.

comment:5 Changed 18 months ago by irl

I've begun this at https://atlas.torproject.org/#advanced.

Not all fields are added yet, so not closing this ticket yet. Still to add:

  • first_seen_days
  • last_seen_days
  • version

comment:6 Changed 18 months ago by cypherpunks

One of the main reasons for opening this ticket was the contact discussion
https://trac.torproject.org/projects/tor/ticket/21366#comment:8
(search=contact:foo vs. contact=foo)

Now I noticed that the current advanced search does not change anything in that regard yet.
Please add a field that uses the contact parameter.

comment:7 Changed 18 months ago by irl

As a hack, I may add parsing the Onionoo query into the backbone.js collections and models.

comment:8 in reply to:  6 Changed 18 months ago by karsten

Replying to cypherpunks:

One of the main reasons for opening this ticket was the contact discussion
https://trac.torproject.org/projects/tor/ticket/21366#comment:8
(search=contact:foo vs. contact=foo)

Now I noticed that the current advanced search does not change anything in that regard yet.
Please add a field that uses the contact parameter.

We're still working on #21366. Better wait for that rather than putting in a workaround into Relay Search. Or plan to take out the workaround again once we're done with the Onionoo change.

comment:9 Changed 18 months ago by irl

Resolution: fixed
Status: acceptedclosed

Fixed in a0beabb.

Once #21366 is done we can revisit this to take advantage of it.

comment:10 Changed 18 months ago by nusenu

Resolution: fixed
Status: closedreopened
Last edited 18 months ago by nusenu (previous) (diff)

comment:11 Changed 18 months ago by nusenu

Resolution: fixed
Status: reopenedclosed

comment:12 Changed 18 months ago by irl

My understanding was that #21366 was going to allow quoted parameters. This does fit your use case and once support is there, we can support quoted parameters in the advanced search form.

I can implement a hacky workaround maybe, what we really need is a JavaScript Onionoo client that supports asynchronous module definition because there are now more places where Onionoo queries are made and to implement the workaround it would be good to only do that in one place.

The relevant commit: https://gitweb.torproject.org/user/karsten/onionoo.git/commit/?h=task-21366&id=695cc74dddb8db32e489874687e21b4d32d1cef1

Last edited 18 months ago by irl (previous) (diff)
Note: See TracTickets for help on using tickets.