Opened 10 months ago

Closed 9 months ago

#23828 closed defect (implemented)

Authorities: Remove IPv6 addresses from microdescriptors

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, review-group-25, review-group-26
Cc: Actual Points: 0.2
Parent ID: #20916 Points: 0.5
Reviewer: Sponsor: SponsorV-can

Description

When #23826 is locked in, we should remove IPv6 addresses from microdescs.

Child Tickets

Change History (9)

comment:1 Changed 10 months ago by teor

Milestone: Tor: 0.3.6.x-finalTor: 0.3.3.x-final
Points: 0.5
Summary: Remove IPv6 addresses from microdescriptorsAuthorities: Remove IPv6 addresses from microdescriptors

comment:2 Changed 10 months ago by teor

Actual Points: 0.2
Sponsor: SponsorV-can

comment:3 Changed 10 months ago by teor

Status: newneeds_review

Actually, it's safe for us to do this in the next consensus method after #23826.

This is implemented in my tor branch bug23826-23828 along with #23826. The corresponding torspec entry is in my torspec branch bug23826-23828, and is tracked in ticket #23898.

comment:4 Changed 10 months ago by teor

Owner: set to teor
Status: needs_reviewassigned

These are all mine

comment:5 Changed 10 months ago by teor

Status: assignedneeds_review

These have code and a proposal in progress on tor-dev@

comment:6 Changed 9 months ago by nickm

Keywords: review-group-25 added

comment:7 Changed 9 months ago by nickm

Status: needs_reviewmerge_ready

This code looks good to me, modulo open questions on proposal 283 [*]. After we discuss them, we should either merge this, or put it into needs_revision, depending on the outcome.

[*] https://lists.torproject.org/pipermail/tor-dev/2017-November/012543.html

comment:8 Changed 9 months ago by nickm

Keywords: review-group-26 added

Creating review-group-26.

comment:9 Changed 9 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Still looks good; squashed and merged to master.

Note: See TracTickets for help on using tickets.