Changes between Initial Version and Version 3 of Ticket #23873


Ignore:
Timestamp:
Dec 24, 2017, 2:30:27 PM (12 months ago)
Author:
teor
Comment:

#23874 unconditionally clears the address, so all that is left here is to remove the return value.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23873

    • Property Parent ID changed from to #24403
    • Property Summary changed from Tor often forgets to check the return value of node_get_prim_orport() to Remove the return value of node_get_prim_orport()
  • Ticket #23873 – Description

    initial v3  
    1 Also, we don't clear the address and port when we fail.
     1~~Also, we don't clear the address and port when we fail.~~
    22
    3 This probably doesn't matter right now, but it matters as soon as we try to change node_get_prim_orport().
     3~~This probably doesn't matter right now, but it matters as soon as we try to change node_get_prim_orport().~~
     4
     5We don't check it, so let's remove it, and check for the null address instead.