Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23874 closed defect (fixed)

Clear the address when node_get_prim_orport() returns early

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: technical-debt, memory-safety, 032-backport, 031-backport, 030-backport, 029-backport, review-group-24
Cc: Actual Points: 0.1
Parent ID: #23975 Points: 0.1
Reviewer: Sponsor:


This is a memory safety thing.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by teor

Status: newneeds_review
Version: Tor:

Please see my branch bug23874-029, because we should probably backport this to 0.2.9 and later.

There may be a merge conflict with a comment that was added later. bug23874 will merge to master.

comment:2 Changed 3 years ago by nickm

Keywords: review-group-24 added

review-group-24 is now open.

comment:3 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to 0.2.9 and forward. I resolved the merge conflict with 9ae4ffc0763fcb0a50d0d02be7d3362cc496adc1 ; please let me know if I messed anything up.

comment:4 Changed 3 years ago by teor

Seems fine to me, thanks for preserving the comment.

comment:5 Changed 3 years ago by teor

Parent ID: #23873#23975

(This was an important part of #23975.)

Note: See TracTickets for help on using tickets.