Clear the address when node_get_prim_orport() returns early

This is a memory safety thing.

changed milestone to %Tor: 0.3.3.x-final

added 029-backport 030-backport 031-backport 032-backport actualpoints::0.1 component::core tor/tor memory-safety milestone::Tor: 0.3.3.x-final parent::23975 points::0.1 priority::medium resolution::fixed review-group-24 severity::normal status::closed technical-debt type::defect version::tor 0.2.8.2-alpha labels

Please see my branch bug23874-029, because we should probably backport this to 0.2.9 and later.

There may be a merge conflict with a comment that was added later. bug23874 will merge to master.

Trac:
Status: new to needs_review
Version: N/A to Tor: 0.2.8.2-alpha

review-group-24 is now open.

Trac:
Keywords: N/A deleted, review-group-24 added

Looks good. Merged to 0.2.9 and forward. I resolved the merge conflict with 9ae4ffc0763fcb0a50d0d02be7d3362cc496adc1 ; please let me know if I messed anything up.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Seems fine to me, thanks for preserving the comment.

(This was an important part of #23975 (moved).)

Trac:
Parent: #23873 (moved) to #23975 (moved)

closed

changed time estimate to 48m

added 48m of time spent

mentioned in issue #24735 (moved)

mentioned in issue #24736 (moved)

moved to tpo/core/tor#23874 (closed)

mentioned in issue tpo/core/tor#24736 (closed)