Opened 9 months ago

Closed 2 months ago

#23883 closed task (implemented)

document how to get Travis CI running on your fork of tor

Reported by: catalyst Owned by: Hello71
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: new-developers, tor-ci, tor-doc, 034-roadmap-subtask, 034-triage-20180328, 034-included-20180328
Cc: Actual Points:
Parent ID: #25550 Points:
Reviewer: catalyst Sponsor: Sponsor3

Description


Child Tickets

Change History (20)

comment:1 Changed 9 months ago by catalyst

Keywords: new-developers tor-ci tor-doc added

comment:2 Changed 7 months ago by asn

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

comment:3 Changed 7 months ago by Hello71

travis:

  1. sign up for GitHub
  2. fork https://github.com/torproject/tor/ (https://help.github.com/articles/fork-a-repo/)
  3. go to https://travis-ci.org/ and log in.
  4. press the profile button in the top right.
  5. search for "tor". if you don't find it, press "Sync account".
  6. enable "tor".
  7. push to GitHub as usual. builds will show up at travis-ci.org and at #tor-ci.

comment:4 Changed 7 months ago by nickm

cool! Do you think you could put this in a patch that we could put somewhere in doc/HACKING -- either in HelpfulTools or GettingStarted ?

comment:5 Changed 7 months ago by catalyst

I'd like us to have some official statement about the torproject/tor GitHub repository before putting these instructions anywhere official.

(I should probably draft one and have isis and other interested people review it, assuming we actually got the group account ownership transferred as planned.)

comment:6 Changed 4 months ago by catalyst

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final
Sponsor: Sponsor3

comment:7 Changed 4 months ago by catalyst

Parent ID: #25550

comment:8 Changed 4 months ago by saper

I have a question - how do we want to keep scripts/instructions in sync with tor's own CI infrastructure?

For example right now I am using libevent and openssl provided by msys64 project, but the CI is building their own.

Also there are some compiler flags being set in the tor project CI that I might want to add.

How to keep all of this synchronized? Do we need to?

comment:9 Changed 4 months ago by nickm

Keywords: 034-roadmap-subtask added

comment:10 Changed 4 months ago by nickm

Keywords: 034-triage-20180328 added

comment:11 Changed 4 months ago by nickm

Keywords: 034-included-20180328 added

comment:12 Changed 3 months ago by Hello71

Status: assignedneeds_review

comment:13 Changed 2 months ago by dgoulet

Reviewer: catalyst

comment:15 Changed 2 months ago by catalyst

Owner: changed from catalyst to Hello71
Status: needs_reviewassigned

comment:16 Changed 2 months ago by catalyst

Status: assignedneeds_revision

Thanks for the patch!

Do we want to recommend travis-ci.com instead of travis-ci.org for people who are new to Travis? It seems like Travis is recommending travis-ci.com for new users.

It should probably specify that #tor-ci is on the OFTC IRC network.

Maybe this needs a changes file?

comment:17 Changed 2 months ago by Hello71

I decided to just point at https://docs.travis-ci.com/user/getting-started/#To-get-started-with-Travis-CI.

I think we should have a page somewhere that shows the current team rotations. Here, I could write "if it doesn't work, ask #tor-dev or the current CI or community whatever member at <x>.".

Good point about specifying the network.

I think this doesn't need a changes file per CodingStandards.md, since nobody will wonder "why did we add the documentation to use Travis". maybe "why did we use Travis", but not why document it.

comment:18 Changed 2 months ago by Hello71

amended commit pushed for review at same place.

comment:19 Changed 2 months ago by catalyst

Status: needs_revisionmerge_ready
Summary: document how to get Travis or GitLab CI running on your fork of tordocument how to get Travis CI running on your fork of tor

Thanks! Looks good to me.

Edited ticket title to narrow scope to Travis.

comment:20 Changed 2 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.