Opened 13 months ago

Closed 9 months ago

#23909 closed defect (fixed)

dirauths write corrupted keypin journal

Reported by: Sebastian Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

When starting my dirauth, I see this line:

[warn] Loaded 56168 entries from keypin journal. Found 5 corrupt lines, 0 duplicates, and 15814 conflicts.

I assume the corrupted lines happen because the file is not atomically written, so if the disk runs full (which occasionally happened in the past due to bwauth issues) we're corrupting the log.

Child Tickets

Change History (9)

comment:1 Changed 13 months ago by Sebastian

Milestone: Tor: 0.3.3.x-final

comment:2 Changed 13 months ago by dgoulet

Component: Core Tor/DirAuthCore Tor/Tor

Moving that to Core Tor/Tor else it will slip through the cracks of the network team :S.

comment:3 Changed 10 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final
Owner: set to nickm
Status: newaccepted

comment:4 Changed 10 months ago by nickm

I think that this is a one-line fix: see branch bug23909 in my public repo.

It's not perfect, but it ought to work a little better than before.

comment:5 Changed 10 months ago by nickm

Status: acceptedneeds_review

comment:6 Changed 10 months ago by nickm

Keywords: review-group-31 added

comment:7 Changed 10 months ago by dgoulet

Reviewer: dgoulet
Status: needs_reviewmerge_ready

lgtm;

comment:8 Changed 10 months ago by nickm

Keywords: review-group-31 removed

Remove merge_ready items that are in 0.3.4 or for backport consideration into 0.3.2 from review-group-31

comment:9 Changed 9 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merging to master (which is now 0.3.4).

Note: See TracTickets for help on using tickets.