Opened 9 years ago

Closed 8 years ago

#2391 closed enhancement (fixed)

Upgrade to use new SQLAlchemy and Elixir

Reported by: mikeperry Owned by: mikeperry
Priority: Medium Milestone:
Component: Core Tor/Torflow Version:
Severity: Keywords:
Cc: aagbsn@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We need to upgrade the version of SQLAlchemy and Elixir we use. This involves some potential API migration:

http://elixir.ematia.de/trac/wiki/Migrate06to07
http://www.sqlalchemy.org/trac/wiki/06Migration

Child Tickets

Change History (8)

comment:1 Changed 9 years ago by aagbsn

Cc: aagbsn@… added

comment:2 Changed 8 years ago by aagbsn

https://github.com/aagbsn/torctl/tree/ticket2391

per SQLAlchemy upgrade notes, just:
# session.clear() is removed. use session.expunge_all().

TODO: test backwards compatibility with old SQLAlchemy and Elixir

comment:3 Changed 8 years ago by mikeperry

Backwards compatibility works. The question is does sqlalchemy 0.7.1? It looks like Elixir hasn't officially been updated for it. Does this mean it works without issues, or that it doesn't work at all?

comment:4 Changed 8 years ago by aagbsn

I tested sqlalchemy 0.7.1 and elixir 0.7.1 and have completed 2 slices without issue.

comment:5 Changed 8 years ago by aagbsn

This was merged into master.

comment:6 Changed 8 years ago by aagbsn

Status: newneeds_review

comment:7 Changed 8 years ago by aagbsn

note: Roger ran into a table error with older (sqlalchemy 0.5.x, elixir 0.6.x) using the Postgres backend. Upgrading to (latest at time of this comment) sqlalchemy 0.7.2 and elixir 0.7.1 resolved this issue.

comment:8 Changed 8 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.