Opened 3 years ago

Closed 2 years ago

#23914 closed enhancement (wontfix)

Extend flag parameter to support comma-separated list of flags

Reported by: nusenu Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


split from

The flag parameter currently does not accept a comma-separated list of flags. We could extend it towards doing so.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by karsten

Owner: changed from metrics-team to karsten
Status: newaccepted

Sounds good to me. We might consider doing #23913 to support queries like search=flag:exit flag:guard rather than search=flag:exit,guard. But we might also support both. I don't feel strongly, even though that might change when I start implementing this. Let's see.

comment:2 Changed 3 years ago by irl

This would be required to allow aggregations in Relay Search of "Fast+Exit".

comment:3 Changed 3 years ago by karsten

Owner: changed from karsten to metrics-team
Status: acceptedassigned

This still seems like a worthwhile enhancement, but I'm not going to find the time to do it anytime soon. Re-assigning to metrics-team for now.

comment:4 Changed 2 years ago by karsten

Owner: changed from metrics-team to karsten
Status: assignedaccepted

Adding this back to my list. Regarding comment 1 above, I'd say let's explicitly support flag=exit,guard now and leave multiple parameters as in flag=exit&flag=guard for all parameters for #23913.

comment:5 Changed 2 years ago by karsten

Status: acceptedneeds_review

comment:6 Changed 2 years ago by karsten

Status: needs_reviewaccepted

Hmm, maybe we can't make this change after all. With the currently planned flag=exit,guard parameter, we'd return relays that have both flags (AND). But if we also add a parameter like lookup=fingerprint1,fingerprint2, we'd return relays with either of the two fingerprints (OR). This might be too confusing, especially if we add more parameters that treat comma-separated values as OR, not AND. Maybe we'll have to fall back to #23913 with two parameters flag=exit and flag=guard to support searches for relays having all required flags (AND). Moving out of review for now.

comment:7 Changed 2 years ago by karsten

Resolution: wontfix
Status: acceptedclosed

Closing this ticket for the reason stated in the previous comment and after leaving a comment on #23913.

Note: See TracTickets for help on using tickets.