Opened 3 years ago

Closed 3 years ago

#23949 closed defect (fixed)

Bug in donation banner prevents display

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201710R
Cc: gk, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


I'm sorry to report the donation banner did not display when it was supposed to, at 2017-10-23T00:00:00. I tracked down the problem to a line in the code that was used for testing:

if (Services.prefs.getBoolPref("extensions.torbutton.testBanner", false)) {

Unfortunately, this line throws an exception if the pref does not exist at all. (The exception causes the banner not to be shown, while no other code is affected.) The second argument to getBoolPref is documented as the "default value" in mozilla-central, but not in mozilla-esr52. It seems I read the mozilla-central documentation, not realizing the second argument was added in Firefox 54.

And further, while I tested the banner with the pref set to true and false, it's clear I didn't test the banner thoroughly enough with the pref deleted.

I apologize for this mistake, especially to Georg and Nicolas who already ran extra builds for the banner.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201710R added; TorBrowserTeam201710 removed
Status: newneeds_review

comment:2 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed on maint-1.9.7 (commit f58bab3851c28fbb8145552349bfdaf62ee1054e) and on master (commit 5feba9668e9d8ec7098d605a1442820282779960). I started a build for 7.0.8 to pick this up. I am not convinced yet that we should do an additional alpha build, though.

Note: See TracTickets for help on using tickets.