Changes between Initial Version and Version 1 of Ticket #23975, comment 11


Ignore:
Timestamp:
Jan 10, 2018, 11:08:38 PM (17 months ago)
Author:
teor
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23975, comment 11

    initial v1  
    11Looks plausible!  It's good to see so much complexity removed here.
    22
    3 I think we already merged #23736, so I'll assume we rebase before the merge to drop 189127acf2014907eac747e25d32668741dc2c5e ?
     3I think we already merged #24736, so I'll assume we rebase before the merge to drop 189127acf2014907eac747e25d32668741dc2c5e ?
    44
    55Let's add a comment to document SET_IPV6_AP.  We should ''especially'' document that it conditionally returns, possibly by renaming it: macros that alter control flow should make it obvious.
    66
    77Other than that, I think I like this.  How is the test coverage for all the functions in policies.c that we modify?
     8
     9Edit: fix ticket number (teor)