Opened 9 years ago

Closed 9 years ago

#2398 closed defect (fixed)

Useless rule in Wikipedia ruleset

Reported by: vbar Owned by: pde
Priority: Very Low Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

<rule from="http://([^@:/]+)\.wik(ipedia|inews|isource|ibooks|iquote|iversity|tionary)\.org/w/index\.php\?title="

to="https://secure.wikimedia.org/wik$2/$1/wiki/"/>

in Wikipedia.xml (of HTTPS Everywhere 0.9.2) doesn't match, apparently because

<rule from="http://([^@:/]+)\.wik(ipedia|inews|isource|ibooks|iquote|iversity|tionary)\.org/(w|wiki)/"

to="https://secure.wikimedia.org/wik$2/$1/$3/"/>

matches first. The matching rule does work, so it's probably not a big deal, but still the unused one takes up space - perhaps the rule sanity checks could be extended to catch this case?

Child Tickets

Change History (1)

comment:1 Changed 9 years ago by pde

Resolution: fixed
Status: newclosed

Fixed in git.

Note: See TracTickets for help on using tickets.