Opened 2 years ago

Last modified 6 months ago

#23988 assigned defect

connection_dir_client_request_failed() not handling HS purposes

Reported by: dgoulet Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When a directory connection didn't finish or maybe timed out, connection_dir_request_failed() is called so we can take appropriate actions depending on the directory purpose.

We do NOT handle any HS purposes which can lead, client side, to having a SOCKS request stuck in RENDDESC_WAIT state if for instance we couldn't query more HSDir after that.

Another problem with this is for the upload descriptor. We usually launch 6 upload to 6 HSDir but if one never finished, this function is called and the HS service subsystem is never notified thus it thinks it was able to upload to all HSDir where in reality one or more are missing. We probably want a callback so we can tell the service to retry on that HSDir or give up on it?

Child Tickets

Change History (7)

comment:1 Changed 2 years ago by dgoulet

Owner: set to dgoulet
Status: newassigned

comment:2 Changed 22 months ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Move 033 ticket I own to 034

comment:3 Changed 21 months ago by nickm

Keywords: 034-triage-20180328 added

comment:4 Changed 21 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:5 Changed 20 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:6 Changed 14 months ago by dgoulet

Status: assignednew
Summary: connection_dir_request_failed() not handling HS purposesconnection_dir_client_request_failed() not handling HS purposes

comment:7 Changed 6 months ago by gaba

Owner: dgoulet deleted
Status: newassigned

Releasing some old tickets.

Note: See TracTickets for help on using tickets.