Opened 18 months ago

Last modified 13 months ago

#24008 accepted defect

service_intro_point_new() should return NULL when passed a NULL extend_info

Reported by: teor Owned by: dgoulet
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.2.1-alpha
Severity: Normal Keywords: prop224, tor-hs, refactor, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points: 0.5
Reviewer: Sponsor:

Description

We pass a NULL extend_info to service_intro_point_new() in the unit tests, and expect a non-NULL return value.

But buggy code could also pass NULL here, and we should return NULL if that happens.

One way to fix this is to split the function into two, and only call the first half in the unit tests.

Child Tickets

Change History (5)

comment:1 Changed 17 months ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

comment:2 Changed 15 months ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Move 033 ticket I own to 034

comment:3 Changed 13 months ago by nickm

Keywords: 034-triage-20180328 added

comment:4 Changed 13 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:5 Changed 13 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.