Test all rust functions' behavior when called from C with bad UTF8

We should make sure that the various rust implementations of our protover functions will correctly detect and reject strings that aren't UTF-8

changed milestone to %Tor: 0.3.3.x-final

added 033-removed-20180320 033-triage-20180320 component::core tor/tor milestone::Tor: 0.3.3.x-final owner::chelseakomlo parent::24265 priority::medium resolution::not a bug rust severity::normal status::closed type::defect labels

Trac:
Status: new to assigned
Owner: N/A to chelseakomlo

Trac:
Parent: N/A to #24265 (moved)

Trac:
Cc: chelseakomlo to chelseakomlo, isis

Marking all tickets reached by current round of 033 triage.

Trac:
Keywords: N/A deleted, 033-triage-20180320 added

Mark all not-already-included tickets as pending review for removal from 0.3.3 milestone.

Trac:
Keywords: N/A deleted, 033-removed-20180320 added

Hmmm, none of the functions are taking &[u8]s, so invalid UTF-8 string will be rejected when the C pointers are read from and converted into Strings. Unless I misunderstood and you wanted something else, we can probably close this?

No, I think we can close this ticket if that's how it works. Thanks for the analysis!

Trac:
Status: assigned to closed
Resolution: N/A to not a bug

If C doesn't reject bad UTF-8, and Rust does, then that's a potential difference in behaviour.

We could avoid this issue by making both C and Rust check that all directory documents are ASCII (#18938 (moved)), or that they are all UTF-8. We have a proposal for making directory documents UTF-8.

closed

mentioned in issue #24265 (moved)

moved to tpo/core/tor#24029 (closed)

mentioned in issue tpo/core/tor#24265 (closed)