Wrap types in protover.rs

Our rust protover implementation throws around HashSet and HashMap with wild abandon. We should probably wrap those types in struct declarations, to make the intent more clear.

changed milestone to %Tor: 0.3.3.x-final

added component::core tor/tor milestone::Tor: 0.3.3.x-final priority::medium resolution::implemented rust severity::normal status::closed type::defect labels

I haven't contributed to Tor before, but this looks like a ticket I could tackle! I'll take a stab a it…

Trac:
Username: frewsxcv

Hi, thanks for taking this on! This will be helpful. Let us know what questions you have or how we can help.

Trac:
Username: frewsxcv
Cc: chelseakomlo to chelseakomlo, coreyf+tor@rwell.org

Thanks for the offer for help! I'll have a branch for this ready soon.

I found some places where heap allocations happen unnecessarily and opened a separate ticket addressing it. Should I assign this ticket to someone?

Also, I'm not very familiar with the Trac workflow, but if it's too time consuming to submit/review/merge tickets with these small changesets, let me know if it's preferable to bundle them together with other commits.

Trac:
Username: frewsxcv

frewsxcv, any progress here?

Yep! I'll try to open a new issue w/ patch for this in the next day or two. Thanks for your patience!

Trac:
Username: frewsxcv

#25067 (moved) it is.

Trac:
Status: new to needs_review

Merged that; thanks, frewsxcv!

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

closed

moved to tpo/core/tor#24030 (closed)