Changes between Initial Version and Version 1 of Ticket #24031, comment 10


Ignore:
Timestamp:
Mar 21, 2018, 4:00:27 AM (14 months ago)
Author:
isis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24031, comment 10

    initial v1  
    11I've cleaned up (mostly! sorry sorry!) my code into more understandable commits in my `bug24031_r4` branch.
    22
    3 The changes to the unittests might be a little hard to follow, that commit is not quite pleasant (although the integration test changes in that same commit should be simple to follow to see where/where behaviour has changed, so I'd argue that the internal unittests changing precariously isn't as much of an issue?).  If test changes (or any changes) are difficult for the reviewer to understand, please feel free to ask questions, or make me split that commit up better.
     3The changes to the unittests might be a little hard to follow, that commit is not quite pleasant (although the integration test changes in that same commit should be simple to follow to see where/when behaviour has changed, so I'd argue that the internal unittests changing precariously isn't as much of an issue?).  If test changes (or any changes) are difficult for the reviewer to understand, please feel free to ask questions, or make me split that commit up better.
    44
    55The other thing is that one test I've added intentionally fails: `protover_all_supported_should_include_version_we_actually_do_support`.  The behavioural difference is this: if we take a protover string `"Link=3-999"` and ask if it is supported, when `"Link=1-5"` ''is'' supported: