Changes between Version 1 and Version 2 of Ticket #24031, comment 10


Ignore:
Timestamp:
Mar 21, 2018, 4:01:27 AM (5 weeks ago)
Author:
isis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #24031, comment 10

    v1 v2  
    55The other thing is that one test I've added intentionally fails: `protover_all_supported_should_include_version_we_actually_do_support`.  The behavioural difference is this: if we take a protover string `"Link=3-999"` and ask if it is supported, when `"Link=1-5"` ''is'' supported:
    66
    7  * the C version returns `"Link=3-999"` (which is, IMHO, wrong, since we ''do'' support 3, 4, and 5.
     7 * the C version returns `"Link=3-999"` (which is, IMHO, wrong, since we ''do'' support 3, 4, and 5).
    88 * the Rust version returns `"Link=6-999"`, which I believe to be the correct implementation of the spec?
    99