Opened 3 years ago

Closed 3 years ago

#24048 closed defect (fixed)

Document which onion service stats include v3 onion services

Reported by: teor Owned by: teor
Priority: Medium Milestone:
Component: Metrics/Statistics Version:
Severity: Normal Keywords:
Cc: Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor:


We should document which metrics stats include v2 and v3 onion services:

The unique onion addresses stat is v2 only:
(See #23126 for a ticket to add v3 support)

But the onion service traffic includes v2 and v3:
(See #24047 for a ticket to split the total into v2 and v3)

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by karsten

Would you want to submit a patch to the JSON file containing graph descriptions?

comment:2 Changed 3 years ago by teor

Actual Points: 0.2
Owner: changed from metrics-team to teor
Points: 0.2
Status: newassigned

comment:3 Changed 3 years ago by teor

Status: assignedneeds_review

Please see my branch bug24048 on for glossary and graph description updates.

comment:4 Changed 3 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Great, thanks for the patch!

I did not take the glossary patch, because I'd like us to keep the definitions at a conceptual level and not start going into implementation details like protocol versions there. Also, starting to talk about versions would mean that we'll have to update the glossary when new versions come and old versions go. I think that the new graph descriptions will work just fine without the glossary update.

I tweaked the new graph descriptions by spelling out the v.

Merged and deployed. Thanks again! Closing.

Note: See TracTickets for help on using tickets.