Opened 3 years ago

Closed 2 years ago

#24078 closed defect (fixed)

metrics-bot should have a better error message when a country has no relays

Reported by: pastly Owned by: irl
Priority: Medium Milestone:
Component: Archived/Metrics Bot Version:
Severity: Normal Keywords:
Cc: Actual Points: 0.04
Parent ID: Points: 0.1
Reviewer: Sponsor:


See also: AS? Maybe. 23650 has no relays (allegedly in China, according to the first google result).

Anyway. I think there should be a different error message for (i) you asked me a question I don't understand, and (ii) I understand the question but have no results.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by irl

Status: newaccepted

comment:2 Changed 2 years ago by irl

Owner: changed from irl to metrics-team
Status: acceptedassigned

I am not immediately working on this ticket. Reassigning to metrics-team to indicate this.

comment:3 Changed 2 years ago by irl

Points: 0.1

comment:4 Changed 2 years ago by irl

Owner: changed from metrics-team to irl
Status: assignedaccepted

comment:5 Changed 2 years ago by irl

Actual Points: 0.04
Resolution: fixed
Status: acceptedclosed

metrics-bot does not know about countries that exist unless they have relays in them, but I've added validation that at least it's a two letter country code being specified with a different message if that validation fails. Similarly, there is a new message for when an AS number is specified that is not a number, as again metrics-bot only knows about ASs when they have relays in them.

This is fixed in ad3d807.

Note: See TracTickets for help on using tickets.