Opened 3 years ago

Closed 3 years ago

#24080 closed defect (fixed)

Make metrics-bot comply with Metrics' project guidelines and java style rules

Reported by: irl Owned by: irl
Priority: Medium Milestone:
Component: Archived/Metrics Bot Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


metrics-bot doesn't comply yet to Metrics' project guidelines and java style rules (like using metrics-base etc.). This has been mostly due to metrics-bot being an exercise in irl relearning Java, but should be fixed now.

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by irl

Status: newaccepted

There's still a whole load of JavaDoc to write here. Checkstyle now has no complaints.

Next up would be to test that metrics-base is helping to build a usable jar, and that the JavaDoc can be built using the metrics-lib Ant snippet.

comment:2 Changed 3 years ago by irl

Resolution: fixed
Status: acceptedclosed

metrics-bot now uses metrics-base, included as a submodule in 178fe2cf, and this produces a working jar file (which is the one used to deploy on DO)

Everything is formatted correctly as of f74675a1.

The only remaining task is to complete JavaDoc, which I will make a new ticket for.

Note: See TracTickets for help on using tickets.