Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2409 closed defect (fixed)

check_signature_token broken in merge commit ed87738ede789fb

Reported by: rransom Owned by:
Priority: Low Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The check_signature_token function (in src/or/routerparse.c) was broken in merge commit ed87738ede789fb: the string "< digest_len" was replaced with "< DIGEST_LEN" on line 1090 (see the last hunk of the diff from the first parent of that commit for src/or/routerparse.c).

This is currently not a problem, as the function's parameter digest_len is always equal to DIGEST_LEN, but we should fix it anyway.

Child Tickets

Change History (6)

comment:1 Changed 9 years ago by rransom

Reported by piebeer.

comment:2 Changed 9 years ago by nickm

Status: newneeds_review

see branch bug2409 in my public repository.

comment:3 Changed 9 years ago by Sebastian

Looks fine to me.

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged; thanks!

comment:5 Changed 7 years ago by nickm

Keywords: tor-client added

comment:6 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.