Opened 8 months ago

Closed 7 months ago

#24137 closed defect (implemented)

Exit flag should not depend on bandwidth

Reported by: Sebastian Owned by: Sebastian
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-25
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Otherwise, in a freshly bootstrapping Tor network, the Exit flag won't be given out.

Child Tickets

Change History (15)

comment:1 Changed 8 months ago by Sebastian

Status: newneeds_review

Bugfix in branch bug24137 in my repo

comment:2 Changed 8 months ago by arma

sebastian: router_counts_toward_thresholds() only returns yes if node->ri, so it makes sense to assert it afterwards. it makes less sense to assert it before.

comment:3 Changed 8 months ago by Sebastian

I don't understand the comment. Is it possible for node->ri to be NULL? If so, that code will now assert or worse, when we remove the assertion, segfault

comment:4 Changed 8 months ago by Sebastian

(What I'm saying is, I can see no possible world where moving the assertion is the right move if we're not also at least introducing an if (ri) check)

comment:5 Changed 8 months ago by Sebastian

Introduced the if in a fixup commit.

comment:6 Changed 8 months ago by nickm

Can this safely be taken in 0.3.3, or is it important to have it in 0.3.2 or earlier?

comment:7 Changed 8 months ago by Sebastian

This can go to 0.3.3.x

comment:8 Changed 8 months ago by Sebastian

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

comment:9 Changed 8 months ago by nickm

Owner: set to Sebastian
Status: needs_reviewassigned

setting owner

comment:10 Changed 8 months ago by nickm

Status: assignedneeds_review

comment:11 Changed 7 months ago by nickm

Keywords: review-group-25 added

comment:12 Changed 7 months ago by nickm

Status: needs_reviewmerge_ready

The code looks okay, and this matches the spec.

Arma, and other dirauth operators: do we anticipate any trouble when authorities start voting "Exit" on routers that don't get counted towards thresholds because their bandwidths are too low?

comment:13 Changed 7 months ago by Sebastian

I don't expect this, because ABSOLUTE_MIN_BW_VALUE_TO_CONSIDER_KB is 4. The top relay atm has a weight of 257000, which means that even if we had 7000 relays at weight 3 that would be negligible in comparison.

comment:14 Changed 7 months ago by arma

Right, I think (I hope) clients will continue using other requirements, like the Fast flag, when deciding which Exit relays to use. This fix just gives clients more opportunities for relays that they probably won't pick, and also reduces confusion for operators who thought they were running Exit relays and don't understand why they are missing the flag.

comment:15 Changed 7 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Okay.  Merged to master!

Note: See TracTickets for help on using tickets.