Opened 2 years ago

Closed 2 years ago

#24156 closed task (fixed)

Remove trailing dash in logs/debootstrap-image-.log filename

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201711R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The build_log option includes var/osname in the filename, however projects/debootstrap-image is special and does not have this defined, so the logs filename is logs/debootstrap-image-.log, which can look like a bug. We should not include that - in the filename when var/osname is not defined.

Child Tickets

Change History (2)

comment:1 Changed 2 years ago by boklm

Keywords: TorBrowserTeam201711R added; TorBrowserTeam201711 removed
Status: newneeds_review

The branch bug_24156 in my git repo has a patch to fix this:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_24156&id=072d3ab7f61733a071ca13a66bdb1fe1922e1e41

Before applying the patch:

$ ./rbm/rbm showconf debootstrap-image build_log --target jessie-amd64
logs/debootstrap-image-.log
$ ./rbm/rbm showconf tor build_log --target torbrowser-linux-x86_64 --target alpha
logs/tor-linux-x86_64.log

After applying the patch:

$ ./rbm/rbm showconf debootstrap-image build_log --target jessie-amd64
logs/debootstrap-image.log
$ ./rbm/rbm showconf tor build_log --target torbrowser-linux-x86_64 --target alpha
logs/tor-linux-x86_64.log

comment:2 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to master (commit 072d3ab7f61733a071ca13a66bdb1fe1922e1e41).

Note: See TracTickets for help on using tickets.