Opened 2 years ago

Closed 2 years ago

#24179 closed defect (fixed)

Tor Browser nightly builds include an old https-everywhere version

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201711R
Cc: legind, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

In projects/https-everywhere/config we are using the master branch for nightly builds, from the git repository https://git.torproject.org/https-everywhere.git

However the master branch on this repository is currently 12 months old.

To fix that, I think we could either:

Child Tickets

Change History (8)

comment:1 Changed 2 years ago by gk

Seems like a deja-vu of #20585?

comment:2 in reply to:  1 Changed 2 years ago by boklm

Replying to gk:

Seems like a deja-vu of #20585?

Yes.

comment:3 Changed 2 years ago by gk

It seems we had/have the same ideas on how to fix it. I guess different repos for nightly builds compared to release/alpha builds is easier doable now with rbm/tor-browser-build. If so, I am fine with that solution.

comment:4 Changed 2 years ago by gk

Keywords: tbb-rbm added

comment:5 in reply to:  3 Changed 2 years ago by boklm

Replying to gk:

It seems we had/have the same ideas on how to fix it. I guess different repos for nightly builds compared to release/alpha builds is easier doable now with rbm/tor-browser-build. If so, I am fine with that solution.

Using different repos will require fixing #24180 (which should be easy), and adding separate makefile rules for fetching commits for release/alpha/nightly. So I think it should be easily doable, but adds a little complexity with more makefile rules.

comment:6 Changed 2 years ago by legind

I suggest using the same tags as in the alpha, since these tags are signed by myself and certainly ready for release. The master branch should be release-ready at any given point in time, but it seems better to be in sync with the actual releases of the extension.

comment:7 in reply to:  6 ; Changed 2 years ago by gk

Cc: boklm added
Keywords: TorBrowserTeam201711R added
Status: newneeds_review

Replying to legind:

I suggest using the same tags as in the alpha, since these tags are signed by myself and certainly ready for release. The master branch should be release-ready at any given point in time, but it seems better to be in sync with the actual releases of the extension.

Okay, no master to test in our nightly builds anymore then. See: bug_24179 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_24179&id=ef2487d3aae2adff9d42a850c39d15e055c6735e) in my tor-browser-build repo for a possible patch.

comment:8 in reply to:  7 Changed 2 years ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

Replying to legind:

I suggest using the same tags as in the alpha, since these tags are signed by myself and certainly ready for release. The master branch should be release-ready at any given point in time, but it seems better to be in sync with the actual releases of the extension.

Okay, no master to test in our nightly builds anymore then. See: bug_24179 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_24179&id=ef2487d3aae2adff9d42a850c39d15e055c6735e) in my tor-browser-build repo for a possible patch.

This looks good. I applied it to master as commit ef2487d3aae2adff9d42a850c39d15e055c6735e.

Note: See TracTickets for help on using tickets.