Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#24180 closed task (fixed)

"rbm fetch" should accept options to select target

Reported by: boklm Owned by: boklm
Priority: Medium Milestone:
Component: Applications/rbm Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201711R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The rbm fetch command is used to fetch new commits from git/hg repositories. It currently takes the following options:

rbm fetch [project]

In tor-browser-build we have a single make fetch command fetching commits from all components, which should work for any type of build (release/alpha/nightly) as they currently all use the same git repositories.

In #24179 however we are thinking about using a different git repository for releases and the nightly build, which means rbm fetch needs to know which type of build we want to fetch, so it should support --target options.

Child Tickets

Attachments (1)

0001-Bug-24180-make-rbm-fetch-accept-options.patch (1.3 KB) - added by boklm 7 months ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 months ago by boklm

Keywords: TorBrowserTeam201711R added
Parent ID: #24179
Status: newneeds_review

I attached a patch to fix that.

To test the patch I made the following change in tor-browser-build:

diff --git a/projects/https-everywhere/config b/projects/https-everywhere/config
index 99290e7..1f9ddd0 100644
--- a/projects/https-everywhere/config
+++ b/projects/https-everywhere/config
@@ -36,4 +36,5 @@ input_files:
 targets:
   nightly:
     version: master
+    git_url: https://github.com/EFForg/https-everywhere
     tag_gpg_id: 0

Then running rbm fetch --target alpha didn't fetch any new https-everywhere commits while rbm fetch --target nightly did.

Last edited 7 months ago by boklm (previous) (diff)

comment:2 Changed 7 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to master (commit 6406e0684a379d13188886f747ed57060925efaf).

comment:3 Changed 7 months ago by boklm

Parent ID: #24179
Note: See TracTickets for help on using tickets.