Opened 22 months ago

Last modified 18 months ago

#24219 needs_revision defect

Avoid aggregate.py error when no nodes are measured

Reported by: teor Owned by:
Priority: Medium Milestone:
Component: Core Tor/Torflow Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #4079 Points:
Reviewer: Sponsor:

Description

If the scanner cron runs early, errors like this can happen:

Traceback (most recent call last):
  File "/Users/bwauth/torflow/NetworkScanners/BwAuthority/aggregate.py", line 894, in <module>
    main(sys.argv)
  File "/Users/bwauth/torflow/NetworkScanners/BwAuthority/aggregate.py", line 798, in main
    nodes.itervalues())))
ValueError: min() arg is an empty sequence

Child Tickets

Change History (8)

comment:1 Changed 22 months ago by teor

Status: newneeds_review

See my branch bug24219 on github. It provides reasonable errors in place of the min() ValueError.

comment:2 Changed 22 months ago by teor

Owner: changed from tom to teor
Status: needs_reviewassigned

comment:3 Changed 22 months ago by teor

Status: assignedneeds_review

comment:4 Changed 22 months ago by teor

Priorities and Severities in torflow are meaningless, setting them all to Medium/Normal.

comment:5 Changed 22 months ago by teor

Parent ID: #4079

Parent to the master logging ticket.

comment:6 Changed 22 months ago by teor

Status: needs_reviewneeds_revision

Marking this as needs r3vision, because Tom said on GitHub that the nodes check is redundant.

comment:7 Changed 18 months ago by teor

Owner: teor deleted
Status: needs_revisionassigned

Someone else can revise this branch if we think it's important

comment:8 Changed 18 months ago by teor

Status: assignedneeds_revision
Note: See TracTickets for help on using tickets.