There needs to be documentation on what kernel versions the KIST Scheduler will run on

changed milestone to %Tor: 0.3.2.x-final

added component::core tor/tor milestone::Tor: 0.3.2.x-final owner::pastly priority::medium reporter::Dbryrtfbcbhgf resolution::fixed reviewer::dgoulet severity::normal status::closed tor-doc tor-sched type::defect labels

*Correction decimation -> documentation

Trac:
Username: Dbryrtfbcbhgf
Summary: There needs to be decimation on what kernel versions the KIST Scheduler will run on to There needs to be documentation on what kernel versions the KIST Scheduler will run on

Trac:
Keywords: N/A deleted, tor-sched added

Trac:
Milestone: N/A to Tor: 0.3.3.x-final

Thanks. I agree this should be documented.

Is this the same Tor instance you are using in #24158 (moved)? I suspect it is, and I suspect your Tor is still running KISTLite. Does that sound correct?

I suspect that to be the case because I've now (re)looked into this. KIST support requires two things:

The tcp_info struct in the kernel having the right members
The SIOCOUTQNSD symbol being defined in a certain header

As long as getsockopt has worked the same for all of time (even before the switch to putting some headers in a "uapi" directory), then the first check for KIST support will pass on kernels AT LEAST as old as 2005's linux-2.6.12-rc2, the first git commit.

The second check will only pass on kernels v2.6.39 or newer.

So it looks like "KIST" will only work if you have v2.6.39 or newer, which is slightly newer than your kernel. "KISTLite" should work regardless of your kernel. Hell, you don't even need to be using Linux.

Now WHERE should we document this? Comment in the source? Man page? Both? Neither? Looking for input from anyone here.

Trac:
Status: new to assigned
Owner: N/A to pastly

Notes from my research in case anyone (including future pastly) will find it useful

607ca46e9 - 2012 move tcpi_snd_cwnd into uapi
1da177e4c - 2005 initial move to git. Linux-2.6.12-rc2 mentioned in commit

2f4e1b39 - 2011 Add SIOCOUTQNSD to include/uapi/linux/sockios.h
           v2.6.39 is the oldest (by version) tag to include this commit

I think this will be very useful in both the man and the source.

My current VPN server is running 2.6.32-042stab120.11.

Trac:
Username: Dbryrtfbcbhgf

Replying to pastly:

Notes from my research in case anyone (including future pastly) will find it useful

{{{ 607ca46e9 - 2012 move tcpi_snd_cwnd into uapi 1da177e4c - 2005 initial move to git. Linux-2.6.12-rc2 mentioned in commit

2f4e1b39 - 2011 Add SIOCOUTQNSD to include/uapi/linux/sockios.h v2.6.39 is the oldest (by version) tag to include this commit }}}

From what I have seen, all the different VPS providers I tested are still using Linux 2.6.32 or below.

Update The owner of a VPS service said "2.6.32 is the highest the OpenVZ kernel goes." so it looks like a large amount a VPS servers can not run "The SIOCOUTQNSD symbol being defined in a certain header"

Trac:
Username: Dbryrtfbcbhgf

Replying to pastly:

Now WHERE should we document this? Comment in the source? Man page? Both? Neither? Looking for input from anyone here. Make a wiki page on trac here?

Replying to cypherpunks:

Replying to pastly:

Now WHERE should we document this? Comment in the source? Man page? Both? Neither? Looking for input from anyone here. Make a wiki page on trac here?

I would go with at least the man page for sure. Requirements for an option in the man page have to be documented there.

(Moving it to 032... I think it was a mistake for this to be in 033.)

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.2.x-final

See ticket24254 for notes added to the man page.

Trac:
Status: assigned to needs_review

lgtm;

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to merge_ready
Keywords: N/A deleted, tor-doc added

Not yet. Rewriting moar to use less jargon and make KISTLite sound better.

Trac:
Status: merge_ready to accepted

Ok ready for review again.

Trac:
Status: accepted to needs_review

cherry-picked to maint-0.3.2 and merging forward. thanks!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#24254 (closed)

There needs to be documentation on what kernel versions the KIST Scheduler will run on

Child items 0

Activity