#24257 closed defect (implemented)

We should specify what is means for a Tor version to be obsolete

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-31, tor-spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

Atlas hit #24256 because our logic for what Tor versions are obsolete is opaque.

We should try to write it down somewhere better than the tor_version_is_obsolete() function. Maybe version-spec.txt is a good location?

Child Tickets

Change History (5)

comment:1 Changed 13 months ago by nickm

Milestone: Tor: 0.3.3.x-final

comment:2 Changed 11 months ago by nickm

Status: newneeds_review

I've tried to do this with ticket24257 in my public torspec repository. Please review?

comment:3 Changed 11 months ago by nickm

Keywords: review-group-31 added

comment:4 Changed 11 months ago by dgoulet

Keywords: tor-spec added
Reviewer: dgoulet
Status: needs_reviewneeds_revision
  • [Will become mandatory.] when... ? Like when we decide or there is a date or when which ticket is resolved?

Considering this comment, I think we can deduce a date no?

+       This field was first added in Tor 0.2.9.x. Some time after all earlier
+       Tor relay versions are obsolete, it will become mandatory.
  • Double white space at the end of the commit.

comment:5 in reply to:  4 Changed 11 months ago by nickm

Resolution: implemented
Status: needs_revisionclosed

Replying to dgoulet:

  • [Will become mandatory.] when... ? Like when we decide or there is a date or when which ticket is resolved?

Considering this comment, I think we can deduce a date no?

+       This field was first added in Tor 0.2.9.x. Some time after all earlier
+       Tor relay versions are obsolete, it will become mandatory.

I think this was in #24023 though. I'll fix it.

  • Double white space at the end of the commit.

Merging and fixing that too.

Thanks!

Note: See TracTickets for help on using tickets.