Opened 8 years ago

Closed 8 years ago

#2427 closed enhancement (implemented)

"Hide duplicates" should hide similar log entries with different parameters

Reported by: StrangeCharm Owned by: atagar
Priority: Medium Milestone:
Component: Core Tor/Nyx Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Arm has the facility to hide duplicate log entries. However, the feature currently only removes log entries whose text is exactly identical. Many log entries produce slightly different text for the same basic entry. For instance:

Possible replay detected! We received an INTRODUCE2 cell with same first part of Diffie-Hellman handshake <t> seconds ago. Dropping cell.

and,

Error launching circuit to node <name> for service <address>.

will produce different text, depending on the specific parameters, but are essentially the same. The second example is especially prone to appearing many times if the connection is interrupted.

Arm should groups these types of entries, and hide them, whether or not the text is exactly identical.

Child Tickets

Change History (1)

comment:1 Changed 8 years ago by atagar

Resolution: implemented
Status: newclosed

Heh, arm actually already does this. If you look in 'src/settings.cfg' under "Snippets from common log messages". The comment explains it, but those are common prefixes and portions of messages to deduplicate when there's dynamic information (like what you mentioned). It's not perfect since it only includes the messages I've seen, but if you submit other deduplication rules to me then I'd be happy to include them (please also include an example message).

Cheers! -Damian

Note: See TracTickets for help on using tickets.