Opened 3 years ago

Closed 2 years ago

#24294 closed enhancement (fixed)

Rename metrics-web packages

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: iwakeh Sponsor:


This ticket is based on a discussion on #24036:

  • Rename root package org.torproject.metrics to org.torproject.metrics.stats to make it part of the Tor Metrics name space.
  • ernie.cron becomes org.torproject.metrics.stats.servers to get rid of the legacy name and to reflect that it's all about servers and bandwidth (provided by servers).
  • org.torproject.metrics.web and subpackages remain unchanged.
  • org.torproject.metrics.web.research, containing just a single class, is merged into org.torproject.metrics.web.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by iwakeh

Owner: changed from metrics-team to iwakeh
Status: newaccepted

Grabbing this, b/c it might need changes in the new build environment #24175.

comment:2 Changed 2 years ago by iwakeh

Owner: changed from iwakeh to metrics-team
Status: acceptedassigned

Move to metrics-team as these are not worked on by me during the next week.

comment:3 Changed 2 years ago by karsten

Owner: changed from metrics-team to karsten
Status: assignedaccepted

I think we can move forward with this. There are three tickets that might have unmerged metrics-web branches and that would be affected by us renaming packages in master: #24823, #24824, and #24996. But all three are relatively small. I'd say let's rename packages now and be done with it.

Grabbing this ticket and preparing a commit in a few days, probably on Tuesday next week. If this sounds like a good or bad idea, please leave a comment.

comment:4 Changed 2 years ago by karsten

I'm working on a patch now.

comment:5 Changed 2 years ago by karsten

Status: acceptedneeds_review

Please review commit 19246a0 in my task-24294 branch.

In addition to the changes listed in the ticket description I also merged org.torproject.metrics.web.graphs into its superpackage. The distinction there was pretty weak anyway and existed only for historical reasons. If we wanted to create a useful subpackage structure for org.torproject.metrics.web, we'd have to start over anyway. But for now it seems okay to just have a single package for all web-related classes.

comment:6 Changed 2 years ago by iwakeh

Reviewer: iwakeh
Status: needs_reviewmerge_ready

Seems fine, i.e., tests and checks pass, re-naming done as planned.
I added a fixup commit that removes special treatment of 'ernie' packages.

Last edited 2 years ago by iwakeh (previous) (diff)

comment:7 Changed 2 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Fixup commit 8d5ce88 looks good! Squashed and merged. Closing. Thanks!

Note: See TracTickets for help on using tickets.