Opened 13 months ago

Closed 2 months ago

#24295 closed enhancement (fixed)

Rename Onionoo packages

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: irl Sponsor:

Description

This ticket is based on a discussion on #24036:

  • Rename root package org.torproject.onionoo to org.torproject.metrics.onionoo to make it part of the Tor Metrics name space.

Child Tickets

Change History (10)

comment:1 Changed 13 months ago by karsten

Maybe we should do #24296 first or in parallel to this ticket, as this package renaming stuff gives us the opportunity to change interfaces without much hassle.

comment:2 Changed 2 months ago by efgyirfe784

Hello all. I created a branch with a proposal for these changes, please feel free to review them:
https://gitlab.com/743zpnpGUq27GgR/onionoo/tree/24295-pkg. Thanks. Josh

comment:3 Changed 2 months ago by karsten

Reviewer: karsten

comment:4 Changed 2 months ago by karsten

Reviewer: karsten

Looks good to me! I made a few tweaks in commit 91c1f86 in my task-24295 branch. Maybe take a look, mainly to get an idea what parts we care about. Overall, good patch, thanks!

irl, I'll leave this in needs_review for you to take another look before I squash and merge. Unassigning myself as reviewer, for you to pick it up.

comment:5 Changed 2 months ago by karsten

Status: newneeds_review

Err, changing to needs_review now.

comment:6 Changed 2 months ago by efgyirfe784

Looks good to me. Good catch with the CHANGELOG! :)
(p.s. not sure if I'm supposed to become the reviewer but I didn't see an option for doing that: Modify->Action doesn't allow me to change anything)

comment:7 Changed 2 months ago by karsten

Thanks for checking, efgyirfe784! And no worries about not being able to become the reviewer. I was hoping that irl would do another review of this patch before it goes in.

comment:8 Changed 2 months ago by irl

Reviewer: irl

Looking at this just now.

comment:9 Changed 2 months ago by irl

Status: needs_reviewmerge_ready

These changes look good to me.

comment:10 Changed 2 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Okay, great! Merged to master. Closing. Thanks!

Note: See TracTickets for help on using tickets.