Opened 9 years ago

Closed 8 years ago

Last modified 7 years ago

#2430 closed defect (fixed)

./autogen.sh fails with autoconf < 2.61

Reported by: Sebastian Owned by:
Priority: Medium Milestone: Tor: 0.2.3.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: tor-client
Cc: barkerjr@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The AC_C_FLEXIBLE_ARRAY_MEMBER macro was introduced in 2.61, and if you use an older version (2.59 in this case) it fails:

autoheader: warning: missing template: FLEXIBLE_ARRAY_MEMBER
autoheader: Use AC_DEFINE([FLEXIBLE_ARRAY_MEMBER], [], [Description])
autoreconf: /usr/bin/autoheader failed with exit status: 1

Maybe we can provide a better warning here, to make sure that people realize they need to upgrade their autoheader?

Reported by xiando on #tor.

Child Tickets

Change History (10)

comment:1 Changed 9 years ago by Sebastian

Component: - Select a componentTor Client

comment:2 Changed 9 years ago by nickm

Milestone: Tor: 0.2.3.x-final

Weird; I thought that the "ifdef" was supposed to catch the case where it wasn't defined. Maybe we need to use m4_ifdef or something like that instead?

comment:3 Changed 8 years ago by arma

Is this still an issue? I'm using debian lenny's 2.13 and I can build master from git.

Perhaps we fixed it somewhere along the line? Or perhaps you don't mean autoconf (or autoheader) when you refer to version 2.61?

comment:4 Changed 8 years ago by arma

(and by lenny i mean squeeze)

wait, i have like four versions of all these things installed. I could still be wrong.

comment:5 Changed 8 years ago by BarkerJr

Cc: barkerjr@… added

$ ./autogen.sh
autoreconf: Entering directory `.'
autoreconf: configure.in: not using Gettext
autoreconf: running: aclocal --force
autoreconf: configure.in: tracing
autoreconf: configure.in: not using Libtool
autoreconf: running: /usr/bin/autoconf --force
autoreconf: running: /usr/bin/autoheader --force
autoheader: warning: missing template: FLEXIBLE_ARRAY_MEMBER
autoheader: Use AC_DEFINE([FLEXIBLE_ARRAY_MEMBER], [], [Description])
autoreconf: /usr/bin/autoheader failed with exit status: 1

$ autoheader --version
autoheader (GNU Autoconf) 2.59
Written by Roland McGrath and Akim Demaille.

Copyright (C) 2003 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ cat /etc/redhat-release
CentOS release 5.6 (Final)
$ uname -srvio
Linux 2.6.36-xenU-4814-x86_64 #2 SMP Tue Mar 1 15:29:19 UTC 2011 x86_64 GNU/Linux

comment:6 Changed 8 years ago by BarkerJr

To note, RHEL/CentOS 6 come with autoheader 2.63, so working to fix this may not be worth it, and rather require users to upgrade to rhel/centos 6.

comment:7 Changed 8 years ago by nickm

Status: newneeds_review

Possible fix in branch 'bug2430' in my public repository. Haven't been able to test it with autoconf 2.59, but it looks like it should work based on what I've been able to find out.

comment:8 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Still looks good to me, and no objections after 3 weeks. Merging this.

comment:9 Changed 7 years ago by nickm

Keywords: tor-client added

comment:10 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.