Opened 9 years ago

Closed 9 years ago

#2431 closed defect (fixed)

Disable the DirPort field in the bridge configuration

Reported by: Sebastian Owned by: chiiph
Priority: Medium Milestone:
Component: Archived/Vidalia Version:
Severity: Keywords:
Cc: bastik.public@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Setting a dirport causes recent Tors to warn, and setting it serves no real purpose on a bridge. DirPort should be set to 0 when configured as a bridge.

Child Tickets

Attachments (1)

vidalia.dirport.patch (1.4 KB) - added by chiiph 9 years ago.
Patch that disables mirror directory and dirport when bridge is enabled

Download all attachments as: .zip

Change History (9)

comment:1 Changed 9 years ago by Sebastian

Status: newneeds_review

Trivial fix in bug2341 in my repo. I don't think this warrants a changes file

comment:2 Changed 9 years ago by Sebastian

Status: needs_reviewassigned

ugh, wrong bug :( sorry chiiph

comment:3 Changed 9 years ago by bastik

Cc: bastik.public@… added

Changed 9 years ago by chiiph

Attachment: vidalia.dirport.patch added

Patch that disables mirror directory and dirport when bridge is enabled

comment:4 Changed 9 years ago by chiiph

Status: assignedneeds_review

comment:5 Changed 9 years ago by edmanm

The patch generally looks good to me. The only thing I would change is that I don't believe you need to set the DirPort to 0 when you are also calling setDirectoryMirror(false). If the user sets up a normal relay and directory mirror, switches to acting as a bridge relay and then switches back, their previous directory port setting would've been erased from vidalia.conf (it gets removed from their torrc anyway) so they'd have to re-enter it. That's a pretty trivial inconvenience, though, and likely an even rarer use case.

comment:6 Changed 9 years ago by chiiph

Right, I missed that. So the final patch just differs in that it doesn't set the DirPort to 0.
Should I commit it?

comment:7 Changed 9 years ago by edmanm

Go for it.

comment:8 Changed 9 years ago by chiiph

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.