Disable the DirPort field in the bridge configuration

Setting a dirport causes recent Tors to warn, and setting it serves no real purpose on a bridge. DirPort should be set to 0 when configured as a bridge.

added component::archived/vidalia owner::chiiph priority::medium resolution::fixed status::closed type::defect labels

Trivial fix in bug2341 in my repo. I don't think this warrants a changes file

Trac:
Status: new to needs_review

ugh, wrong bug :( sorry chiiph

Trac:
Status: needs_review to assigned

Trac:
Points: N/A to N/A
Cc: N/A to bastik.public@gmx-topmail.de

Trac:
vidalia.dirport.patch

Patch that disables mirror directory and dirport when bridge is enabled

Trac:
Status: assigned to needs_review
Actualpoints: N/A to N/A

The patch generally looks good to me. The only thing I would change is that I don't believe you need to set the DirPort to 0 when you are also calling setDirectoryMirror(false). If the user sets up a normal relay and directory mirror, switches to acting as a bridge relay and then switches back, their previous directory port setting would've been erased from vidalia.conf (it gets removed from their torrc anyway) so they'd have to re-enter it. That's a pretty trivial inconvenience, though, and likely an even rarer use case.

Right, I missed that. So the final patch just differs in that it doesn't set the DirPort to 0. Should I commit it?

Go for it.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed