Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#2433 closed defect (fixed)

tls context not re-initialized when changing relay/bridge state

Reported by: Sebastian Owned by:
Priority: High Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This means that a Vidalia-controlled Tor will assert when changing from relay to bridge. Unfortunately, restarting Tor does not help this situation at all, the same assert will happen again (I guess Vidalia realizes that Tor hasn't written its configuration and that it should have a different config, so it applies the change again, and Tor crashes again).

The assert is:

[err] assert_identity_keys_ok(): Bug: router.c:154: assert_identity_keys_ok: Assertion 0!=crypto_pk_cmp_keys(client_identitykey, server_identitykey) failed; aborting.

I think what we need to do here is to make sure we re-initialize our tls context whenever we change our public_server_mode().

Child Tickets

Change History (6)

comment:1 Changed 8 years ago by Sebastian

Component: - Select a componentTor Relay

comment:2 Changed 8 years ago by Sebastian

Status: newneeds_review

Proposed fix in branch bug2433 in my repository.

comment:3 Changed 8 years ago by rransom

bug2433 looks good to me.

comment:4 Changed 8 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged this yesterday. thanks!

comment:5 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:6 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.