Opened 4 months ago

Closed 5 weeks ago

#24343 closed defect (fixed)

Remove dead code and doc regarding the old SocksSocket option

Reported by: dgoulet Owned by: dgoulet
Priority: Low Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-doc, deadcode, review-group-32
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:


In entry_connection_t, there is still is_socks_socket option that is simply not used.

Other place is this log which should be renamed to mention "Unix socket".

    log_info(LD_NET, "Closing SOCKS SocksSocket connection");

Finally, the man page is still listing the option within another option (although SocksSocketsGroupWritable is still a thing that we should probably rename).

       SocksSocketsGroupWritable 0|1
     If this option is set to 0, don’t allow the filesystem group to read and write unix sockets (e.g. SocksSocket). If the option
     is set to 1, make the SocksSocket socket readable and writable by the default GID. (Default: 0)

Child Tickets

Change History (5)

comment:1 Changed 6 weeks ago by dgoulet

Status: assignedneeds_review

Most of it is code removal except for the configuration option.

I've moved SocksSocketsGroupWritable to become an alias for the new name UnixSocksGroupWritable because that option only applies to Unix socket for the SocksPort.

Branch: ticket24343_033_01

comment:2 Changed 5 weeks ago by nickm

Keywords: review-group-32 added

comment:3 Changed 5 weeks ago by asn

Reviewer: asn

comment:4 Changed 5 weeks ago by asn

Status: needs_reviewmerge_ready

LGTM! :)

comment:5 Changed 5 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

merging to maint-0.3.3 and forward!

Note: See TracTickets for help on using tickets.