Opened 3 years ago

Closed 3 years ago

Last modified 13 months ago

#24362 closed enhancement (fixed)

Add logging backend for Android

Reported by: ahf Owned by: ahf
Priority: Low Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Minor Keywords: s8
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor8


On some devices the Android platform will send messages send to the classical Unix syslog service to Android's ringbuffer log that can be read via a USB cable with the adb tool.

Since we are unsure if *every* Android device does this automatic conversion from Syslog to Android's logging system, it might make sense to have an "Log <severity> android" line for torrc like we currently have with "Log <severity> syslog" in the case we have a technical user with a device that does NOT send syslogs to the Android log who found, or is willing to debug, some issues for us.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by ahf

Owner: set to ahf
Status: newassigned

comment:2 Changed 3 years ago by ahf

Status: assignedneeds_review

comment:3 Changed 3 years ago by nickm

Status: needs_reviewneeds_revision

Looks pretty good to me, but I had a small suggestion, and a question about a function name.

comment:4 Changed 3 years ago by ahf

Status: needs_revisionneeds_review

I added an additional patch with some simplification and added a question to your suggestion on using tor_asprintf().

comment:5 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

all looks reasonable. merging!

comment:6 Changed 13 months ago by eighthave

FYI, the canonical macro name for Android is __ANDROID__ like the other OS macros. This merge request used USE_ANDROID. I'll submit a merge request to fix this.

You can get an overview by doing:

grep --no-filename -rF ANDROID /opt/android-sdk/ndk-bundle/ |sort -u|grep def
Note: See TracTickets for help on using tickets.