I see you included a change file. That's awesome. Nick loves that.
Are you aware of the ./scripts/maint/lintChanges.py script? Your changes file doesn't pass the script because "Minor change" isn't one of the known headings. Peeking at the source of the script, if it was me making this change and wanting to please the Tor gods maintainers, I'd probably use "Code simplification and refactoring"
It still takes me about 3 attempts to please the script :). You call it like ./scripts/maint/lintChanges.py changes/ticket24363 and silence indicates success.
I see you included a change file. That's awesome. Nick loves that.
Are you aware of the ./scripts/maint/lintChanges.py script? Your changes file doesn't pass the script because "Minor change" isn't one of the known headings. Peeking at the source of the script, if it was me making this change and wanting to please the Tor gods maintainers, I'd probably use "Code simplification and refactoring"
It still takes me about 3 attempts to please the script :). You call it like ./scripts/maint/lintChanges.py changes/ticket24363 and silence indicates success.