Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#24363 closed defect (fixed)

Remove /usr/athena from search path in configure.ac

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-26
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It may have made sense to use this directory in 2002, but even MIT project Athena systems don't have it any more, I'm told.

Child Tickets

Attachments (1)

0001-Remove-usr-athena-from-search-path-in-configure.ac.patch (1.4 KB) - added by ffmancera 7 months ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 months ago by ffmancera

Status: newneeds_review

The attached patch solves the ticket.

comment:2 Changed 7 months ago by pastly

Thanks for the patch!

I see you included a change file. That's awesome. Nick loves that.

Are you aware of the ./scripts/maint/lintChanges.py script? Your changes file doesn't pass the script because "Minor change" isn't one of the known headings. Peeking at the source of the script, if it was me making this change and wanting to please the Tor gods maintainers, I'd probably use "Code simplification and refactoring"

It still takes me about 3 attempts to please the script :). You call it like ./scripts/maint/lintChanges.py changes/ticket24363 and silence indicates success.

Last edited 7 months ago by pastly (previous) (diff)

comment:3 in reply to:  2 Changed 7 months ago by ffmancera

Oh thank you! I didn't know about the script. I corrected it and re-uploaded the patch.

Replying to pastly:

Thanks for the patch!

I see you included a change file. That's awesome. Nick loves that.

Are you aware of the ./scripts/maint/lintChanges.py script? Your changes file doesn't pass the script because "Minor change" isn't one of the known headings. Peeking at the source of the script, if it was me making this change and wanting to please the Tor gods maintainers, I'd probably use "Code simplification and refactoring"

It still takes me about 3 attempts to please the script :). You call it like ./scripts/maint/lintChanges.py changes/ticket24363 and silence indicates success.

comment:4 Changed 7 months ago by nickm

Keywords: review-group-26 added

Creating review-group-26.

comment:5 Changed 7 months ago by nickm

looks good; merged it to master.

comment:6 Changed 7 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

comment:7 Changed 7 months ago by teor

(For future reference, I can never remember the path to the changes script, I use "make check-changes")

Note: See TracTickets for help on using tickets.