Add unreachable or addresses to details view and a synthetic flag

This originally came up in #10401 (moved) for IPv6, but as it's possible that IPv4 ports may also be unreachable, this should be addressed seperately.

added component::metrics/relay search owner::irl priority::medium resolution::fixed severity::normal status::closed type::enhancement labels

Moving into my queue.

Trac:
Owner: metrics-team to irl
Status: new to accepted

This flag only applies to IPv6. And it will not be shown, as long there are a majority of ReachableIPv6 authorities voting for each and every consensus.

Here's why:

• relays with unreachable IPv4 ORPorts are always marked as not Running, and excluded from the consensus. Their addresses never appear in onionoo's unreachable_orports field, because they are never included in the consensus
• if a majority of voting authorities have IPv6, IPv6 ORPorts are treated the same as IPv4 ORPorts.
• if a minority of voting authorities have IPv6, some IPv6 addresses may appear in unreachable_orports, but the numbers will be small (see Karsten's graphs on #23761 (moved))

Reference: https://metrics.torproject.org/onionoo.html#details_relay_unreachable_or_addresses

So if one of the 5 IPv6 authorities stops IPv6 or goes down, this feature will be very useful. Otherwise, it won't get used at all. (We didn't know this until after #23761 (moved), and more authorities adding IPv6, and the consensus-health ReachableIPv6 feature.)

The Onionoo description for this field is:

Array of IPv4 or IPv6 addresses and TCP ports or port lists where the relay claims in its descriptor to accept onion-routing connections but that the directory authorities failed to confirm as reachable. Contains only additional addresses of a relay that are found unreachable and only as long as a minority of directory authorities performs reachability tests on these additional addresses. Relays with an unreachable primary address are not included in the network status consensus and excluded entirely. Likewise, relays with unreachable additional addresses tested by a majority of directory authorities are not included in the network status consensus and excluded here, too. If at any point network status votes will be added to the processing, relays with unreachable addresses will be included here.

It's the possibility of adding votes later (which I would like to see happen) that I would like to have covered.

Fixed in 6643de6.

Trac:
Status: accepted to closed
Resolution: N/A to fixed

closed