A bunch of hidden service warnings should be protocol warnings

[Sebastian]

We've had quite a few reports about log messages such as:

Possible replay detected! We received an INTRODUCE2 cell with same first part of Diffie-Hellman handshake 5 seconds ago.

and

INTRODUCE2 cell is too old. Discarding

These are messages that an operator can't do anything about, and they should be in the protocol warnings category instead.

[nickm]

It would be nice if somebody did this.

[arma]

In general I agree with you about moving warns to protocol-warns if there's nothing the operator can do about it. But in the case you raise this is a warning at a hidden service. It's quite possible that hidden service was legitimately under some sort of protocol-level attack. If you get a lot of these as a hidden service operator, you really should consider turning off your hidden service, investigating, etc.

Maybe that's what the log message should tell them to do?

[rransom]

See ​bug2442-v2 ( https://git.torproject.org/rransom/tor.git bug2442-v2 ) for a fix. This branch includes the fix for #3989.

[nickm]

Merging this into 0.2.2: The impact isn't high, but the risk is negligible, and rransom says that otherwise he'll have a pile of conflicts with other HS fixes that 0.2.2 should have unless this gets in.