#24443 closed defect (fixed)

moat gives out QRcodes when we didn't ask for them

Reported by: isis Owned by: isis
Priority: Medium Milestone:
Component: Obfuscation/BridgeDB Version:
Severity: Minor Keywords: moat, bridgedb-dist
Cc: brade, mcs Actual Points: .2
Parent ID: Points: .5
Reviewer: Sponsor: SponsorM

Description

From #24433:

Actually, heh. From the above output, there's another bug (although it shouldn't stop testing). It's giving a QR when we said we didn't need one. I guess it's nice to know the server is enthusiastic about sending images anyway (and that it works).


We'll need to make sure that JSON requests with {"qrcode": "false"} are actually respected before we release this to actual clients, since (if Tor Launcher doesn't need the QRcode) it's a waste of bandwidth and memory.

Child Tickets

Change History (1)

comment:1 Changed 13 months ago by isis

Actual Points: .2
Resolution: fixed
Status: newclosed

Fixed in my fix/24443 branch.

If the JSON has "qrcode": "true" somewhere in it, you'll get a QRcode returned with the bridges. Anything else, no QRcode.

Note: See TracTickets for help on using tickets.