Opened 5 months ago

Last modified 3 months ago

#24458 new enhancement

Specify Onionoo's query and search syntax

Reported by: iwakeh Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by iwakeh)

This applies especially to the different encoding types in UrLs and form data.
See comments 4 and 8 in #24234, which is blocked by this ticket.

Most burning questions are:

  • what to expect regarding plus encoding: + or %2B or decode plus into space
  • how to treat other percent encoded characters
  • ...

References:
rfc3986

Child Tickets

Change History (10)

comment:1 Changed 5 months ago by iwakeh

Description: modified (diff)

comment:2 Changed 5 months ago by iwakeh

Repeating a part of comment 4 in #24384:

The three possible encodings of plus are each perfectly valid in there context. If plus is used as a separator it should stay +, form encoding turns plus (for historical reasons) into spaces, and if plus is part of the data it should be percent encoded.

comment:3 Changed 5 months ago by iwakeh

Description: modified (diff)

comment:4 Changed 5 months ago by karsten

I'm not sure how to move this forward.

My analysis in #24384 pointed out some issues in Relay Search, which need fixing or at least clarification.

My idea was to wait until Relay Search does something that conforms to standards and then make sure Onionoo responds accordingly.

If it turns out that Onionoo needs to do something that is not exactly standard, like not decode + to spaces, we'll have to see how to build that. For example, it might be that we cannot leave parameter parsing to Jetty anymore.

If you have a better idea to move this ticket forward without first looking at #24384, please go ahead!

comment:5 Changed 5 months ago by iwakeh

The standard(s) Onionoo wants to confirm to need to be chosen/defined. As said above, the decoding of plus to space is only a historic part of form submission. Keeping plus or do the percent encoding is valid according to URI/URL encoding (as pointed out in comment 4 #24384). Thus, it needs to be decided what Onionoo expects and once a standard is chosen the open parts or deviations (all mostly regarding encoding) need to be added to the search-definition (of course, making sure Onionoo conforms to them in first place).
Relay Search should follow Onionoo's standard, which should have Relay Search in mind when working on this ticket in order to minimize the development efforts for both products.

comment:6 Changed 3 months ago by iwakeh

See also #21366 and #24311.

comment:7 in reply to:  4 Changed 3 months ago by irl

Replying to karsten:

My idea was to wait until Relay Search does something that conforms to standards and then make sure Onionoo responds accordingly.

Are you still waiting? I can't remember if I did things for this or not.

We may need to coordinate these changes as if I change the way RS is encoding queries and Onionoo isn't ready, it all breaks.

comment:8 Changed 3 months ago by karsten

This is still marked as "need to do something with this" in my list. Sorry!

comment:9 Changed 3 months ago by irl

Does that mean I need to do things or you need to do things?

comment:10 Changed 3 months ago by karsten

I need to do things.

Note: See TracTickets for help on using tickets.