Opened 11 months ago

Last modified 2 weeks ago

#24465 needs_revision defect

Snowflake broken if no libatomic on host

Reported by: isabela Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: snowflake, tbb-rbm, TorBrowserTeam201809
Cc: isabela, mikeperry, mcs, isis, nickm, gk, brade, catalyst, iry, adrelanos, arlolra, boklm, dcf Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by isabela)

OS: Debian stretch

TB alpha 7.5a8

Tor Browser logs:

​https://share.riseup.net/#H0k8k6BxXvsOGMq2CODCfg

steps to reproduce error:

  1. click on configure
  1. select snowflake
  1. try to connect
  1. error shows up (screenshot: https://trac.torproject.org/projects/tor/attachment/ticket/24465/error-screenshot-snowflake-missing.png)

Child Tickets

Attachments (1)

error-screenshot-snowflake-missing.png​ (43.4 KB) - added by isabela 11 months ago.
screenshot of error - snowflake missing

Download all attachments as: .zip

Change History (22)

Changed 11 months ago by isabela

Attachment: error-screenshot-snowflake-missing.png​ added

screenshot of error - snowflake missing

comment:1 Changed 11 months ago by isabela

Description: modified (diff)

comment:2 Changed 11 months ago by dcf

Keywords: snowflake added

comment:3 Changed 11 months ago by gk

Status: new → needs_information

Works for me on a Debian system with a clean 7.5a8. Have you tried with a fresh bundle as well?

Another user on #tor today confirmed that snowflake on Linux with Tor Browser 7.5a8 worked around a Tor block done by the local university.

comment:4 Changed 11 months ago by mcs

For what its worth, I am also unable to reproduce this. I tried on an Ubuntu 14.04.5 system with a Tor Browser that was upgraded from 7.5a6 to 7.5a8.

I wonder if snowflake-client is crashing or refusing to start, and why.

comment:5 Changed 8 months ago by cypherpunks

Component: Applications/Tor Launcher → Applications/Tor Browser
Keywords: TorBrowserTeam201802 added
Owner: changed from brade to tbb-team
Status: needs_information → assigned
Summary: 'missing pluggable transport ' error when trying to connect to Tor using snowflake → Snowflake broken if no libatomic on host

The issue seems to be reproducible per the info provided in duplicate #25087.

Last edited 8 months ago by cypherpunks (previous) (diff)

comment:6 Changed 8 months ago by arlolra

Cc: arlolra added

comment:7 Changed 8 months ago by gk

Keywords: TorBrowserTeam201803 added; TorBrowserTeam201802 removed

Adding to our March plate.

comment:8 Changed 7 months ago by gk

Keywords: TorBrowserTeam201804 tbb-rbm added; TorBrowserTeam201803 removed
Parent ID: #24371
Status: assigned → needs_information

boklm: Could you test (using steps in #25087) whether the GCC update in #25304 solves this issue?

comment:9 Changed 7 months ago by gk

Cc: boklm added

comment:10 in reply to:  8 Changed 7 months ago by boklm

Replying to gk:

boklm: Could you test (using steps in #25087) whether the GCC update in #25304 solves this issue?

After the gcc update, snowflake-client is still linked to libatomic.so.1, so it seems it didn't solve the issue.

comment:11 Changed 5 months ago by gk

Keywords: TorBrowserTeam201805 added; TorBrowserTeam201804 removed

Moving remaining tickets to May.

comment:12 Changed 5 months ago by cypherpunks

Status: needs_information → new

comment:13 Changed 5 months ago by cypherpunks

Keywords: ux-team removed

comment:14 Changed 5 months ago by dcf

Cc: dcf added

comment:15 Changed 4 months ago by gk

Keywords: TorBrowserTeam201806 added; TorBrowserTeam201805 removed

Moving our tickets to June 2018

comment:16 Changed 4 months ago by gk

Keywords: TorBrowserTeam201807 added; TorBrowserTeam201806 removed

More tickets for July.

comment:17 Changed 3 months ago by gk

Keywords: TorBrowserTeam201808 added; TorBrowserTeam201807 removed

Move our tickets to August.

comment:18 Changed 2 months ago by sukhbir

Status: new → needs_review

For review:

​https://github.com/azadi/tor-browser-build-1/tree/bug-24465

Note that this simply copies the library from gcc/libs. Perhaps we can do something similar for #25485, where we first try to run snowflake-client and if it fails, then only we add it libatomic.so to LD_LIBRARY_PATH. Is that preferred?

I reproduced and tested this on Lubuntu 17.10.

comment:19 in reply to:  18 Changed 2 months ago by gk

Replying to sukhbir:

For review:

​https://github.com/azadi/tor-browser-build-1/tree/bug-24465

IIRC this was a 64but-only problem but you are copying the lib for 32bit as well which seems to be not needed (if I got the history of this bug right).

Note that this simply copies the library from gcc/libs. Perhaps we can do something similar for #25485, where we first try to run snowflake-client and if it fails, then only we add it libatomic.so to LD_LIBRARY_PATH. Is that preferred?

We could do that. But we eventually want to get rid of LD_LIBRARY_PATH I think and not add another workaround to this workaround if possible. So, I wonder if this bug would be a good start to look into compiling with a relative -rpath. See: #13373 and #13359 where I did some initial work some years ago.

I reproduced and tested this on Lubuntu 17.10.

comment:20 Changed 6 weeks ago by gk

Keywords: TorBrowserTeam201809 added; TorBrowserTeam201808 removed

Moving our tickets to September 2018

comment:21 Changed 2 weeks ago by gk

Status: needs_review → needs_revision
Note: See TracTickets for help on using tickets.