Opened 2 years ago
Closed 3 months ago
#24465 closed defect (fixed)
Snowflake broken if no libatomic on host
Reported by: | isabela | Owned by: | tbb-team |
---|---|---|---|
Priority: | Medium | Milestone: | |
Component: | Applications/Tor Browser | Version: | |
Severity: | Normal | Keywords: | snowflake, tbb-rbm, tbb-easy |
Cc: | isabela, mikeperry, mcs, isis, nickm, gk, brade, catalyst, iry, adrelanos, arlolra, boklm, dcf | Actual Points: | |
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description (last modified by )
OS: Debian stretch
TB alpha 7.5a8
Tor Browser logs:
https://share.riseup.net/#H0k8k6BxXvsOGMq2CODCfg
steps to reproduce error:
- click on configure
- select snowflake
- try to connect
- error shows up (screenshot: https://trac.torproject.org/projects/tor/attachment/ticket/24465/error-screenshot-snowflake-missing.png)
Child Tickets
Attachments (1)
Change History (27)
Changed 2 years ago by
Attachment: | error-screenshot-snowflake-missing.png added |
---|
comment:1 Changed 2 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 2 years ago by
Keywords: | snowflake added |
---|
comment:3 Changed 2 years ago by
Status: | new → needs_information |
---|
Works for me on a Debian system with a clean 7.5a8. Have you tried with a fresh bundle as well?
Another user on #tor today confirmed that snowflake on Linux with Tor Browser 7.5a8 worked around a Tor block done by the local university.
comment:4 Changed 2 years ago by
For what its worth, I am also unable to reproduce this. I tried on an Ubuntu 14.04.5 system with a Tor Browser that was upgraded from 7.5a6 to 7.5a8.
I wonder if snowflake-client is crashing or refusing to start, and why.
comment:5 Changed 22 months ago by
Component: | Applications/Tor Launcher → Applications/Tor Browser |
---|---|
Keywords: | TorBrowserTeam201802 added |
Owner: | changed from brade to tbb-team |
Status: | needs_information → assigned |
Summary: | 'missing pluggable transport ' error when trying to connect to Tor using snowflake → Snowflake broken if no libatomic on host |
The issue seems to be reproducible per the info provided in duplicate #25087.
comment:6 Changed 22 months ago by
Cc: | arlolra added |
---|
comment:7 Changed 21 months ago by
Keywords: | TorBrowserTeam201803 added; TorBrowserTeam201802 removed |
---|
Adding to our March plate.
comment:8 follow-up: 10 Changed 20 months ago by
Keywords: | TorBrowserTeam201804 tbb-rbm added; TorBrowserTeam201803 removed |
---|---|
Parent ID: | #24371 |
Status: | assigned → needs_information |
comment:9 Changed 20 months ago by
Cc: | boklm added |
---|
comment:10 Changed 20 months ago by
comment:11 Changed 19 months ago by
Keywords: | TorBrowserTeam201805 added; TorBrowserTeam201804 removed |
---|
Moving remaining tickets to May.
comment:12 Changed 19 months ago by
Status: | needs_information → new |
---|
comment:13 Changed 18 months ago by
Keywords: | ux-team removed |
---|
comment:14 Changed 18 months ago by
Cc: | dcf added |
---|
comment:15 Changed 18 months ago by
Keywords: | TorBrowserTeam201806 added; TorBrowserTeam201805 removed |
---|
Moving our tickets to June 2018
comment:16 Changed 17 months ago by
Keywords: | TorBrowserTeam201807 added; TorBrowserTeam201806 removed |
---|
More tickets for July.
comment:17 Changed 17 months ago by
Keywords: | TorBrowserTeam201808 added; TorBrowserTeam201807 removed |
---|
Move our tickets to August.
comment:18 follow-up: 19 Changed 16 months ago by
Status: | new → needs_review |
---|
For review:
https://github.com/azadi/tor-browser-build-1/tree/bug-24465
Note that this simply copies the library from gcc/libs
. Perhaps we can do something similar for #25485, where we first try to run snowflake-client
and if it fails, then only we add it libatomic.so
to LD_LIBRARY_PATH
. Is that preferred?
I reproduced and tested this on Lubuntu 17.10.
comment:19 follow-up: 22 Changed 16 months ago by
Replying to sukhbir:
For review:
https://github.com/azadi/tor-browser-build-1/tree/bug-24465
IIRC this was a 64bit-only problem but you are copying the lib for 32bit as well which seems to be not needed (if I got the history of this bug right).
Note that this simply copies the library from
gcc/libs
. Perhaps we can do something similar for #25485, where we first try to runsnowflake-client
and if it fails, then only we add itlibatomic.so
toLD_LIBRARY_PATH
. Is that preferred?
We could do that. But we eventually want to get rid of LD_LIBRARY_PATH
I think and not add another workaround to this workaround if possible. So, I wonder if this bug would be a good start to look into compiling with a relative -rpath
. See: #13373 and #13359 where I did some initial work some years ago.
I reproduced and tested this on Lubuntu 17.10.
comment:20 Changed 15 months ago by
Keywords: | TorBrowserTeam201809 added; TorBrowserTeam201808 removed |
---|
Moving our tickets to September 2018
comment:21 Changed 14 months ago by
Status: | needs_review → needs_revision |
---|
comment:22 Changed 13 months ago by
Status: | needs_revision → needs_review |
---|
Replying to gk:
Replying to sukhbir:
For review:
https://github.com/azadi/tor-browser-build-1/tree/bug-24465
IIRC this was a 64but-only problem but you are copying the lib for 32bit as well which seems to be not needed (if I got the history of this bug right).
The original logs had expired (the share.riseup.net link) so I decided to check and it seems like this issue affects both the 32- and 64-bit versions.
The branch with the rebased changes is at https://github.com/azadi/tor-browser-build-1/tree/bug-24465-rev1
comment:23 Changed 13 months ago by
Keywords: | TorBrowserTeam201811R added; TorBrowserTeam201809 removed |
---|
comment:24 Changed 13 months ago by
Keywords: | TorBrowserTeam201811R removed |
---|---|
Status: | needs_review → needs_revision |
If just snowflake requires libatomic.so
then let's make sure the library does not get unconditionally included but only if we are actually building and distributing snowflake (which is not the case for the current release series and might still not be the case for the coming one). We have var/snowflake
for that.
comment:25 Changed 3 months ago by
Keywords: | tbb-easy added |
---|
comment:26 Changed 3 months ago by
Resolution: | → fixed |
---|---|
Status: | needs_revision → closed |
There is no GCC involved anymore in compiling dependencies for snowflake. Thus, I think with the purely Go-based version we have right now (see: #25483). This bug is gone, too.
screenshot of error - snowflake missing