#24475 closed task (fixed)

Add support for Windows 64 to update-responses

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201712R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

We need to update the update-responses script to:

  • generate incremental mar files for win64
  • generate update xml for win64 users

Child Tickets

Change History (6)

comment:1 Changed 22 months ago by gk

Sponsor: Sponsor4

Sponsor4 stuff.

comment:2 Changed 22 months ago by gk

Moving tickets to December 2017

comment:3 Changed 22 months ago by gk

Keywords: TorBrowserTeam201712 added; TorBrowserTeam201711 removed

Moving tickets to December 2017, for realz.

comment:4 Changed 22 months ago by boklm

I made a patch for that in branch bug_24475:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_24475&id=6a8ad8477573ae4aef73b4a001012d1c3ec6b36b

However I did not test it yet, as I don't have a build with win64 mar files yet. I will do that once my build for tbb-7.5a9-build3 is finished.

comment:5 Changed 22 months ago by boklm

Keywords: TorBrowserTeam201712R added; TorBrowserTeam201712 removed
Status: newneeds_review

I rebased the patch on master in branch bug_24475_v2:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_24475_v2&id=5a274fb97d317860e59592ec37a6ce9f3a007fd9

I tried it using a build of tbb-7.5a9-build3, and the generated downloads.json, .htaccess, and .xml files look good.

comment:6 Changed 22 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to master as commit 5a274fb97d317860e59592ec37a6ce9f3a007fd9.

Note: See TracTickets for help on using tickets.