Opened 3 years ago

Closed 2 years ago

#24476 closed defect (duplicate)

make_full_update.sh and make_incremental_update.sh should do a "set -e"

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201805
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

The scripts make_full_update.sh and make_incremental_update.sh from the directory tor-browser.git/tools/update-packaging are missing a set -e, which would make it easier to detect failures. Currently if there is an error in the script, an error is printed in the logs, but the script still exits with 0.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by gk

Sponsor: Sponsor4

Sponsor4 stuff.

comment:2 Changed 3 years ago by gk

Moving tickets to December 2017

comment:3 Changed 3 years ago by gk

Keywords: TorBrowserTeam201712 added; TorBrowserTeam201711 removed

Moving tickets to December 2017, for realz.

comment:4 Changed 3 years ago by gk

Keywords: TorBrowserTeam201801 added; TorBrowserTeam201712 removed

Moving tickets to 2018.

comment:5 Changed 3 years ago by gk

Keywords: TorBrowserTeam201802 added; TorBrowserTeam201801 removed

Moving tickets to Feb

comment:6 Changed 2 years ago by gk

Keywords: TorBrowserTeam201803 added; TorBrowserTeam201802 removed

Adding to our March plate.

comment:7 Changed 2 years ago by gk

Keywords: TorBrowserTeam201804 added; TorBrowserTeam201803 removed

Moving our tickets to April.

comment:8 Changed 2 years ago by gk

Keywords: TorBrowserTeam201805 added; TorBrowserTeam201804 removed

Moving remaining tickets to May.

comment:9 Changed 2 years ago by gk

Resolution: duplicate
Status: newclosed

Dealt with during the rebase in #25543.

Note: See TracTickets for help on using tickets.