Opened 10 months ago

Closed 10 months ago

Last modified 8 months ago

#24478 closed defect (fixed)

Enable tests and debug assertions in our ASan builds

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201712R, GeorgKoppen201712, tbb-rbm, tbb-no-uplift
Cc: boklm, arthuredelstein Actual Points:
Parent ID: #24154 Points:
Reviewer: Sponsor: Sponsor4

Description

We should make a full debug build with our ASan build(s) in order to allow us better to fuzz them.

Child Tickets

Change History (4)

comment:1 Changed 10 months ago by gk

Keywords: TorBrowserTeam201712R added; TorBrowserTeam201712 removed
Sponsor: Sponsor4
Status: newneeds_review

bug_24478 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_24478&id=6c889e3bd6a3dec009f11b5b648b20bdfcaafb3f) is up for review. I've been doing several local builds with that configuration locally over the last couple of days (taking #21925 into account) and it works for me.

comment:2 Changed 10 months ago by boklm

This change looks good to me.

comment:3 Changed 10 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Applied to tor-browser-52.5.2esr-7.5-1 as commit e17e2c643eea02103a25470b946e9e6c4c11b24c.

comment:4 Changed 8 months ago by arthuredelstein

Keywords: tbb-no-uplift added
Note: See TracTickets for help on using tickets.