Opened 3 months ago

Closed 3 months ago

#24489 closed enhancement (fixed)

Add some consts to networkstatus_getinfo_by_purpose()

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: code-correctness, review-group-27
Cc: Actual Points: 0.1
Parent ID: Points: 0.1
Reviewer: dgoulet Sponsor:

Description

We shouldn't modify any of the data structures passed to networkstatus_getinfo_by_purpose(). But the current design modifies the running flag in the GETINFO.

The patch I'm about to post makes sure we don't accidentally modify any more of the data structures.

Thanks to komlo - the patch was her idea, and she helped create it.

Child Tickets

Change History (7)

comment:1 Changed 3 months ago by teor

Status: newneeds_review

Please see my branch bug24489 on github, which adds some consts and a note for future refactoring.

I opened a follow-up ticket to avoid the bridge authority changing the running flag in networkstatus_getinfo_by_purpose(). See #24490.

comment:2 Changed 3 months ago by nickm

Keywords: review-group-27 added

comment:3 Changed 3 months ago by nickm

Owner: set to teor
Status: needs_reviewassigned

setting owner

comment:4 Changed 3 months ago by nickm

Status: assignedneeds_review

comment:5 Changed 3 months ago by dgoulet

Reviewer: dgoulet

comment:6 Changed 3 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:7 Changed 3 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged to master!

Note: See TracTickets for help on using tickets.