#24514 closed defect (fixed)

The dmg2mar script does not have an option to select the tmp dir

Reported by: boklm Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201712R, tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Similarly to #23899, the dmg2mar script extract files in a tmp directory, but does not have an option to select which tmp directory to use.

Child Tickets

Change History (3)

comment:1 Changed 18 months ago by gk

Keywords: tbb-rbm added

comment:2 Changed 17 months ago by boklm

Keywords: TorBrowserTeam201712R added; TorBrowserTeam201712 removed
Status: newneeds_review

It seems the File::Temp->newdir() function that we use in dmg2mar will use the directory from the TMPDIR environment variable if it exists. So defining TMPDIR to the tmp_dir value from the rbm config before running the dmg2mar should fix the issue.

I added a patch doing that to branch bug_24514:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_24514&id=c4db919cd945f421f36ec1c358bce15ecc192590

comment:3 Changed 17 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Merged to master (commit c4db919cd945f421f36ec1c358bce15ecc192590).

Note: See TracTickets for help on using tickets.