Opened 12 months ago

Last modified 7 months ago

#24535 new defect

Document which address functions we should use, and when

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, doc, 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: #24403 Points: 1
Reviewer: Sponsor: SponsorV-can

Description

nickm says that there are a lot of ways to get an address in Tor.

Let's document the functions that are left at the end of #23975, and when each of them should be used. It would be nice to have a summary, and then also details in each function comment.

We'll need to include these functions:

  • node_get_*_*port()
  • *_choose_address()
  • any others?

Child Tickets

Change History (7)

comment:1 Changed 12 months ago by teor

We might also want to include:

  • extend_info_from_node()
  • the link specifier functions

comment:2 Changed 11 months ago by teor

And the functions that get onion keys.

comment:3 Changed 11 months ago by teor

Parent ID: #23975#24403

This will be easier to do once the IPv6 DirPort code is removed in #24403.

comment:4 Changed 10 months ago by teor

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

The 0.3.3 freeze deadline has passed, all these children of #24403 belong in 0.3.4

comment:5 Changed 8 months ago by nickm

Keywords: 034-triage-20180328 added

comment:6 Changed 8 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:7 Changed 7 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.