Opened 3 months ago

Last modified 3 weeks ago

#24535 new defect

Document which address functions we should use, and when

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: ipv6, doc
Cc: Actual Points:
Parent ID: #24403 Points: 1
Reviewer: Sponsor: SponsorV-can

Description

nickm says that there are a lot of ways to get an address in Tor.

Let's document the functions that are left at the end of #23975, and when each of them should be used. It would be nice to have a summary, and then also details in each function comment.

We'll need to include these functions:

  • node_get_*_*port()
  • *_choose_address()
  • any others?

Child Tickets

Change History (4)

comment:1 Changed 3 months ago by teor

We might also want to include:

  • extend_info_from_node()
  • the link specifier functions

comment:2 Changed 2 months ago by teor

And the functions that get onion keys.

comment:3 Changed 8 weeks ago by teor

Parent ID: #23975#24403

This will be easier to do once the IPv6 DirPort code is removed in #24403.

comment:4 Changed 3 weeks ago by teor

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

The 0.3.3 freeze deadline has passed, all these children of #24403 belong in 0.3.4

Note: See TracTickets for help on using tickets.