Opened 11 months ago

Closed 7 months ago

#24544 closed defect (fixed)

Fix more prop224 spec inconsistencies

Reported by: asn Owned by: asn
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, prop224, 033-triage-20180320, fast-fix, 033-included-20180326, post-stable
Cc: Actual Points:
Parent ID: Points: 0.3
Reviewer: dgoulet Sponsor:

Description

inkylatenoth pointed various inconsistencies between spec and code:
https://lists.torproject.org/pipermail/tor-dev/2017-October/012527.html

A few of them have been addressed by Filipo in #24342, but not all of them.

We should address the rest of them.

Child Tickets

Change History (11)

comment:1 Changed 11 months ago by dgoulet

Owner: set to asn
Reviewer: dgoulet
Status: newassigned

comment:2 Changed 8 months ago by nickm

Keywords: 033-triage-20180320 added

Marking all tickets reached by current round of 033 triage.

comment:3 Changed 8 months ago by nickm

Keywords: 033-removed-20180320 added

Mark all not-already-included tickets as pending review for removal from 0.3.3 milestone.

comment:4 Changed 8 months ago by dgoulet

Keywords: 033-mustfix added; 033-removed-20180320 removed

This is really quick. We just need to go over the proposed fixes. It is very important that we have rend-spec-v3.txt reflecting the implementation perfectly.

comment:5 Changed 8 months ago by dgoulet

Keywords: fast-fix added; 033-mustfix removed

comment:6 Changed 8 months ago by nickm

Keywords: 033-included-20180326 added

comment:7 Changed 7 months ago by asn

Keywords: post-stable added

Marking this as post-stable since it's a spec patch and shouldn't be release-blocking!

comment:8 Changed 7 months ago by asn

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Triaging this to 0.3.4.

comment:9 Changed 7 months ago by asn

Status: assignedneeds_review

Pushed branch bug24544 in my github repo with a potential patch for the issues pointed out in ​https://lists.torproject.org/pipermail/tor-dev/2017-October/012527.html.

See https://github.com/torproject/torspec/pull/3

comment:10 Changed 7 months ago by dgoulet

Status: needs_reviewmerge_ready

lgtm;

comment:11 Changed 7 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged it!

Note: See TracTickets for help on using tickets.