Opened 8 months ago

Closed 7 months ago

#24572 closed defect (fixed)

rewrite_node_address_for_bridge() doesn't set rs IPv6 addresses

Reported by: teor Owned by: ffmancera
Priority: Medium Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.5-alpha
Severity: Normal Keywords: ipv6, easy, intro, tor-bridge-client
Cc: Actual Points:
Parent ID: #24573 Points: 0.5
Reviewer: teor Sponsor: SponsorV-can

Description

rewrite_node_address_for_bridge() should set the IPv6 address in rs, as well as setting the one in ri. We can copy the code from ri.

This goes back to commit 9e9edf71f7d in tor 0.2.4.5-alpha.

This is unlikely to have caused any bugs since at least 0.2.8, because node_get_*_or_addr() checks the ri before the rs.

But let's fix it anyway, for consistency and better logging.

(Eventually, we will rip out this code when we make ri and rs read-only.)

Child Tickets

Change History (4)

comment:1 Changed 8 months ago by teor

Keywords: easy tor-bridge-client added; easy. removed
Sponsor: SponsorV-can

comment:2 Changed 8 months ago by teor

Owner: set to ffmancera
Parent ID: #20916#24573
Reviewer: teor
Status: newassigned

#24573 includes this code, we should update its changes file to match.
Let's review there.

comment:3 Changed 8 months ago by teor

Status: assignedneeds_revision

comment:4 Changed 7 months ago by ffmancera

Resolution: fixed
Status: needs_revisionclosed
Note: See TracTickets for help on using tickets.